Html/Css/Js used and it was a good example for learning DOM

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Change width to max-width in your component’s container to make it responsive. You will also want to delete the height as it is unnecessary.

  • The “icons/images” in this component serve no other purpose than to be decorative; They add no value. There alt Ttag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  furkan 🧑🏻‍🎨•30

  @furkankucukkirisPosted almost 2 years ago

  @vcarames thanks a lot. I will consider your suggestions :)

  0
• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hello furkan, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To make the submit button work only when the user selects a number, we can do this:

  rates.forEach((rate) => {
      rate.addEventListener('click', () => {
          rate.style.backgroundColor = 'grey';
          rate.style.color = 'white';
          rating.innerHTML = rate.innerHTML;
          submitButton.addEventListener('click', () => {
              mainContainer.style.display = 'none';
              thanksContainer.style.display = 'flex';
          });
      })
  })
  

  The remainder is excellent.

  I hope it's useful. 👍

  0

  ---

  

  furkan 🧑🏻‍🎨•30

  @furkankucukkirisPosted almost 2 years ago

  Hey @AdrianoEscarabote. Thanks a lot. I will consider your suggestions :)

  1

  

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  @furkankucukkiris happy coding!

  Marked as helpful

  1
• 

  Cris Augusto•160

  @Cristhyam-AugustoPosted almost 2 years ago

  Hi Furka how are you?? Congratulations on the design, it was really identical. I did a project like this yesterday, and I got some feedback that might be useful for you too: I noticed that I can send a review even without filling in the value, so you can change the code as below to avoid this.

    rate.addEventListener("click", () => {
      rate.style.backgroundColor = "grey";
      rate.style.color = "white";
      rating.innerHTML = rate.innerHTML;
      submitButton.addEventListener("click", () => {
        mainContainer.style.display = "none";
        thanksContainer.style.display = "flex";
      });
    });
  }); 
  

  I also noticed that in the html you used ID and class references for the LI, but I don't think that's necessary, because you used only classes in css. In general I think that's it, congratulations on the work, it was really good.

  0

  ---

  

  furkan 🧑🏻‍🎨•30

  @furkankucukkirisPosted almost 2 years ago

  Hey @Cristhyam-Augusto. Thanks a lot. I will consider your suggestions :)

  0