HTML,CSS,and text editor VSCODE

Community feedback

• 

  Karen Robertson•190

  @indigorosePosted about 1 month ago

  This is a really nice solution to this challenge.

  The HTML is easy to read, however for the next challenge try to extend your use of semantics, such <main> or <section> rather than <div>.

  It helps us to see the flow of the page better and improve accessibility.

  Most use the cheat sheet from the Mozilla MDN site MDN Web Docs Cheat Sheet.

  For the text responsiveness, the clamp() css function has been helpful with sizing responsive text MDN description.

  There is also letter-spacing and line-height in css that will also help with the text design requirements.

  Even without the Figma files, the site is still impressive and meets the responsive requirements.

  Hope to see your other solutions soon.

  Marked as helpful

  0

  ---

  

  Rafi Rachmawan•150

  @rafirachmawanPosted about 1 month ago

  Thank you for your input, yes it is very true that the HTML structure does not use semantics and I am very grateful for your input, I will update my source code. @indigorose

  0
• 

  P

  Jose•170

  @josenegrete123Posted about 1 month ago

  Great work! For your @media section of the CSS, you don't need to change the font-size around because per the figma documents, they are all the same font-size, from mobile-version to desktop. Also the h1 and the first span should be in a different font. But that was given in the style-guide. The line-height in the h1 could also be change to 0.

  Marked as helpful

  0

  ---

  

  Rafi Rachmawan•150

  @rafirachmawanPosted about 1 month ago

  Thank you very much sir, I will replace it immediately and I will update it soon @josenegrete123

  0