html-css_3 column card

Community feedback

• 

  P

  Katrien Schuermans•1,210

  @katrien-sPosted about 3 years ago

  Hi, the code looks nice and so does the page. Though I'd like to advise you to clean up your code. You have lots of empty lines, or the text of the assignment still hidden as a comment on your html. Part of writing code is also presenting your work clean. Any empty space or hidden comment, adds to the size of your file. It's not a big issue now, but it will once the projects get bigger. It also makes your code harder to read.

  As for the responsiveness, did you check it on tablet size? The cards become really really small and impossible to read. Try to add an extra media-query for a bigger size. Also, it would be better practice to work with min-width as opposed to max-width. It will save you a lot of code in the future, because when working with min-width, one only adds code as a media-query. If you work the other way around, you need to eliminate code, which is a lot harder. Especially on bigger projects.

  Keep on coding!

  0