Design comparison
SolutionDesign
Solution retrospective
Any feedback will be apreciated.-
Community feedback
- @rfilenkoPosted over 4 years ago
Hi, you can improve your solution a little bit:
- first, you should fix cors problems( fonts and reset.css aren't properly loaded);
- use mediaqueries for responsive, not external js file needed for this;
- semantic html tags, heading hierarchy;
- img {max-width: 100%};
- use classes to avoid repetions in css;
- define links in nav and footer;
- only li are allowed inside ul;
- hover states;
Keep up with practicing, Roman
0@Nicolaj123Posted over 3 years ago@rfilenko Thank you for your feedback. I´ll try to check those things.
Thank you for your reply!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord