Design comparison
Solution retrospective
Hello guys ! Third project complete, the first with the "mobile first" approach, and I am quite satisfied with the final result !
The only little probleme int this state, is when I resize (pass from mobile view to desktop view), all my animation are restarted, and I didn't find any solution for this problem without JS.
Cheers
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Loic2A, Congratulations on completing this challenge!
🎨 Here are some tips to improve your component design:
1.You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.2.Its really nice that you’ve used some animation and effects! Something to improve the accessibility its to add a media query reducing the motion.The prefers-reduced-motion CSS media feature is used to detect if the user has requested that the system minimize the amount of non-essential motion it uses. Here’s the code for that:
/* Remove all animations, transitions and smooth scroll for people that prefer not to see them */ @media (prefers-reduced-motion: reduce) { html:focus-within { scroll-behavior: auto; } *, *::before, *::after { animation-duration: 0.01ms !important; animation-iteration-count: 1 !important; transition-duration: 0.01ms !important; scroll-behavior: auto !important; } }
✌️ I hope this helps you and happy coding!
1@Loic2APosted about 2 years ago@correlucas Hello ! Thanks for the advices, 2 more tags that I didn't know existed ahah
Thanks men !
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord