Skip to content
Submitted almost 3 years ago

HTML,CSS

Samsoor•120
@Samsoor-nan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Clément Creusat•1,655
    @ccreusatPosted almost 3 years ago

    Hello ! Cool challenge!

    Some suggestions :

    • center your component width the <body> tag. Something like that :
    display: flex;
 flex-direction: column;
place-content: center;
background-color: hsl(212, 45%, 89%);
place-items: center;
min-height: 100vh;

    • remove the background-color: hsl(212, 45%, 89%); on your full-site container and remove 100% width, not needed

    • I think it's better to have a max-width: 320px on your component instead of your width: 22% ( why this by the way? :) )

    • You should add a reset on your html, a simple one :

    *,
*::before,
*::after {
margin: 0;
padding: 0;
box-sizing: border-box
}

    box-sizing: border-box

    Then it would look awesome ! :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord