Submitted about 2 years ago
HTML/CSS, Flexbox, Git & Gitflow, and Positioning
@Have-Samuel
Design comparison
SolutionDesign
Solution retrospective
Hello Guys,
Happy Weekend,
Ideas, Suggestions, Comments are all we;lcome. Thank
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @Have-Samuel ๐, good job on completing this challenge! ๐
Here are some suggestions you might consider:
- The
<h1>
element is the main heading on a web page. There should only be one<h1>
tag per page. The HTML Section Heading elements (Reference). This case requires thatSUVS
,SEDANS
, andLUXURY
be<h2>
elements. - Instead of using pixels in font size, use relative units of measure like
rem
orem
. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference. - Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img class="top-image" src="./images/icon-sedans.svg" alt aria-hidden="true"> <img class="top-image" src="./images/icon-suvs.svg" alt aria-hidden="true"> <img class="top-image" src="./images/icon-luxury.svg" alt aria-hidden="true">
I hope those tips will help you.
Good job, and happy coding!
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord