html,css

Community feedback

• 

  Tom Roche•330

  @TomrocheDevPosted 6 months ago

  Good take on this solution! The design looks really good and professional.

  You request on help with cleaning up your code: First of all, your code looks fine to me. You use the right tags, which makes your code structured. What I would avoid, is the over-use of classnames. Not all tags need a classname (in my opinion). The thing I also would avoid, is the long classnames like "container__section_header_div_name", "container__section_texto1" and "container__section_texto2". These long classnames make your code hard to read, and it also makes elements hard to target when you want to change something. Like, when I read your CSS, I have to puzzle my way out to find out which properties are assigned to which element.

  I would recommend to use short and declaritive classnames and try experimenting with targeting elements without classnames. This way you will learn how to target elements effectively without overusing classnames. A great resource for this is CSS Diner. https://flukeout.github.io/

  Hope this helps!

  Marked as helpful

  0

  ---

  

  Alejandro•430

  @adelayglesiafleitasPosted 6 months ago

  Hi @TomrocheDev Thank you very much for taking the time to provide me with feedback on my code. I appreciate your suggestions on keeping class names concise and meaningful, as well as experimenting with targeting elements without relying heavily on class names. I will definitely take your advice on board and work on improving the readability and maintainability of my code. Thank you once again for your valuable input! I really appreciate it.

  0