Design comparison
SolutionDesign
Solution retrospective
Any feedback on areas where i need an improvement will be very helpful
Community feedback
- @ChamuMutezvaPosted about 3 years ago
- when you use a div to do the work of a button , you need to add in the right aria attributes for it to be identified as a button by assistive tech users. The below will not be beneficial to assistive tech users.
<div class="burger" id="mobile-menu"> <div class="bar"></div> <div class="bar"></div> <div class="bar"></div> </div>
- the following are not
p
elements but anchor elements and should be nested in an unordered list
<div class="div4one"> <p>About</p> <p>Services</p> <p>Projects</p> </div>
- the responsiveness is good. Well done
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord