HTML,CSS and Javascript

Community feedback

• 

  Divine Obeten•2,415

  @Deevyn9Posted almost 3 years ago

  Hi Tarik, your Solution is great and functional, good work.

  Marked as helpful

  1

  ---

  

  tarik310•230

  @tarik310Posted almost 3 years ago

  @Deevyn9 thank you very much

  1

  

  Divine Obeten•2,415

  @Deevyn9Posted over 2 years ago

  @tarik310 you’re welcome

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  👋 Hello Tarik , Wonderful solution , it looks responsive & works correctly , Well Done 🤩🤩🤩

  Since this is your first JS challenge , your hard work has paid off !! However I think you should follow some tutorials to create javascript projects because there are lot of stuff you should know before creating complex projects. For example you are listening for keyup events but instead you should be listening for change events.

  Other than that your solution is cool & keep coding this amazing solutions 👍

  Marked as helpful

  1

  ---

  

  tarik310•230

  @tarik310Posted almost 3 years ago

  @abhik-b thank you for the feedback. 🤗

  1
• 

  Thomas Kressman•110

  @tkressmaPosted almost 3 years ago

  Hey there! Great solution - it works as it should. The web app is very responsive as well!

  I have one general tip for you. In JavaScript, there is a concept called Event delegation.

  Consider your code: on lines 52,56, 94-98 and 183-187, you create many separate event listeners to perform the same event upon being clicked: ActivatingReset(), erasevalueoncustom(), makeCalculations().

  Using Event delegation, you can apply a single event listener to the parent container (class="percent") and have whatever child you click on "bubble" up towards the event listener. This will allow your code to follow the D.R.Y. principle.

  For example, you can replace all of those repetitive lines of code with this:

  document.querySelector(".percent") .addEventListener('click', event => { if (event.target.className === 'percentBtn') { //Assign inputs a class of "percentBtn" makecalculations(); } });

  You can read more here: https://dmitripavlutin.com/javascript-event-delegation/, but certaintly watch some YouTube videos on this powerful concept. Happy coding!

  0

  ---

  

  tarik310•230

  @tarik310Posted almost 3 years ago

  @tkressma thank you very much sir for this great feedback.

  1