html,css and css flex box

Community feedback

• 

  Hassan Aziz•60

  @bauerceptorPosted 2 months ago

  Hi Zakir Mustafa,

  I reviewed your work and it is awesome. Here are all the nice things I found in your code:

  1. It was structured and readable.
  2. The layout looked good on a range of screen-sizes.
  3. The solution was nearly identical to the design.

  However, here are some things I noticed that can be worked upon:

  1. A separate CSS file for styles could have made the solution reusable.
  2. The Responsive Media Query could have been set to 420px because between 420 to 300px, the site did not look as awesome as before.
  3. The HTML could have been more semantic, for example, there could have been a figure element at top level, with image, figcaption and aside/p as the children elements instead of divs.

  Overall, I appreciate your effort and hard-work and I would love for you to continue developing amazing stuff. Best of luck!

  p.s. Use GitHub Pages to host your project repo for free on GitHub.

  0