HTML,CSS and Bootstrap 4

Community feedback

• 

  P

  Katrien Schuermans•1,210

  @katrien-sPosted about 4 years ago

  Try working with a mobile first-approach. It makes coding a lot easier as you run into less problems when moving on to different sizes.

  Also, it's a bad idea to name your classes 'part1', 'part2'. When someone else reads your code, they have no clue what they're reading. Because you're on a small project now, it's still easy to figure out, but once you start building webpages, it will be harder for others to read.

  To make your component more responsive, change the padding and margin from px to rem or em. Pixels are static values.

  Besides that, nicely done. Happy coding!

  1

  ---

  

  Rohit Dubey•335

  @rohitdubey1352Posted about 4 years ago

  @graficdoctor thanks for your response I will do more focus on class names and also using rem and em.

  0
• 

  T

  Grace•31,270

  @grace-snowPosted about 4 years ago

  Hi, I think you need to look again at the mobile view. The paddings very large, so content isn't lining up between sections and one bit of content is missing for me. I'll add a screenshot on slack for you so you can see what I'm seeing. Keep going ☺

  1

  ---

  

  Rohit Dubey•335

  @rohitdubey1352Posted about 4 years ago

  @grace-snow thanks for your feedback, now the page is responsive. I fix it : )

  1

  

  T

  Grace•31,270

  @grace-snowPosted about 4 years ago

  @rohitdubey1352 well done, much better.

  I still think the paddings/spacings are a bit large but looks pretty good.

  Only other thing I'd change is there's a few places where you've done font sizes in pixels. Probably worth changing that to rems too, as it's making those few bits of text way smaller than the rest.

  Good job tho!

  0