Design comparison
Solution retrospective
Appreciate reviews
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h2> with <h1> to fix the accessibility issues.
Add aria-label attribute
aria-label=" "
to the <a> of the social media icons to fix the error and accessibility issue. The value of the aria-label is the description of the image. For more aria-label click herefor the left and right sides of the page, give the main a width of 80vw and margin: 0 auto
main{ width:80vw; margin: 0 auto; }
give the img a max-width of 100% for a responsive content.
In the desktop design add a background-size of cover to the body and in the media query add a background-size of contain to the body.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord