HTML,CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Sukhmani, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from .container class
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  2

  ---

  

  Sukhmani Arora•10

  @Sukhmani252Posted over 2 years ago

  @denielden Thank you so much for reviewing, these suggestions are really helpful.

  I'll make these changes.

  These important suggestions help a lot in growing and staying motivated.

  1
• 

  Mahmoud ELshora•40

  @elshoraPosted over 2 years ago

  That's cool.. you did well.

  I think there is an issue, you need to center your main container. you can use flex to make it.

  search on youtube if you need more info.

  1

  ---

  

  Sukhmani Arora•10

  @Sukhmani252Posted over 2 years ago

  @elshora Thanks for the feedback.

  Yaa, actually I was having some issues in making it responsive.

  I'll try again.

  0