HTML,CSS

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @Samsoor-nan ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • On smaller devices, card goes over screen, and I think max-width: 100% can solve this issue.
  • Please try BEM for naming element classes. It will help you a lot on bigger projects.
  • There is no hover effects on image and other elements. It's also one of challenging part here.
  • Font sizes and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  1
• 

  Samsoor•120

  @Samsoor-nanPosted almost 3 years ago

  Dear Tymur,

  Thank you for your detailed reply and giving time to read my solution. points raised by you are correct and I will try my best to meet them,

  Best Regards Samsoor

  0