HTML/CSS

Community feedback

• Account deleted

  Hi there!! ✌️

  Congrats on completing this challenge! 🥳🎉

  Solving your question... No, it's not necessary, your code works fine like this.

  BUT... your code has some bugs, here are some tips to improve it. ✅

  HTML 🧱

  Your content should be inside the main tag.

  CSS 🎨

  Your reset is small, it's ok. But you can improve it with the following popular resets: 🚀

  • Normalize.css
  • Reset.css
  • My Custom CSS Reset of Josh Comeau

  I recommend that you learn the BEM methodology, this methodology is a way to name the classes of the nodes of your HTML and then attack them with CSS in an easy, simple and clear way. 💯🚀

  Your code is really good 💯, keep it up don't give up!!! 🙃

  I hope I've helped you 😄

  Happy coding! 👨‍💻

  Marked as helpful

  1

  ---

  

  erntTt•30

  @erntTtPosted about 1 year ago

  @FLCHRIS Thanks for the answer and the recommendations. For HTML - Yes totally agree. For CSS - Thanks for the useful links, but the second one isnt working :(

  0

  Account deleted

  @erntTt

  Excuse me brother 😥

  Here is the link reset.css

  1
• 

  Nguyễn Đức Chính•310

  @chinh1402Posted about 1 year ago

  Hello there ✌, congrat on finishing the challenge. In this specific challenge, there's no need for media queries because their layouts are the same.

  I'll give some suggestions to improve your solution

  1. The space around the image you gave is kind of too big, I suggest shrinking it a bit
  2. There is a lot of white space at the bottom of the card, and there's not enough space between the headline of the card and the image. I suggest moving both headline and description texts down using margin.

  Hopefully you find those suggestions useful.

  Happy coding! 😁

  Marked as helpful

  1

  ---

  

  erntTt•30

  @erntTtPosted about 1 year ago

  @chinh1402 Thanks for the suggestions :)

  0
• 

  mattroddev•90

  @mattroddevPosted about 1 year ago

  Greetings, I'm new here as well. In my rookie opinion, it doesn't need a media query. As long as it looks good on mobile and desktop, you're golden. I am doing my best to use semantic HTML for every project I do so I don't end up creating some 'div soup.' Here is a quick read I found about media queries: https://dev.to/kathryngrayson/you-probably-dont-need-media-queries-anymore-a4j If you centered up that .attribution class, I think it would make your work look better. Good job. Have a good one.

  Marked as helpful

  1

  ---

  

  erntTt•30

  @erntTtPosted about 1 year ago

  @mattroddev Really useful link.. thanks!

  0