Design comparison
SolutionDesign
Solution retrospective
How's this code , any further improvement or suggestion !!!!
Community feedback
- @rsrclabPosted almost 3 years ago
Hi, @krtksharma ~
Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Here are some of the tips I like to provide.
- On smaller devices, responsiveness doesn't work well, and I think that's because of
viewport
meta on html head. - I suggest you to try transition on hoverable elements like heading and creator name.
- Please try BEM for naming element classes. It will help you a lot on bigger projects.
- Font sizes and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.
- Eye icon wasn't centered on image overlay.
https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH
Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.
Cheers ~
1@krtksharmaPosted almost 3 years ago@tymren608 Thanks for your valuable feedback....
0 - On smaller devices, responsiveness doesn't work well, and I think that's because of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord