HTML,css

Community feedback

• 

  Davide•1,725

  @Da-vi-dePosted over 3 years ago

  Hi, i don't really like your choice of implementing CSS in style element, you should have a saperated CSS file, that's the professional way of working.

  • You didn't really follow the task, the background must cover the entire page, in practice means you need to selet the body element and set the background there.

  • id should be used for JS, ids are unique so you can't reuse it again, it's a problem for bigger projects because you end up writing everything twice or more... Never underestimate reusability.

  • I strongly advice you to learn mobile first approach and HTML semantic, a right way to start would be checking your report and try to resolve the issues.

  Keep coding :-)

  Marked as helpful

  0

  ---

  

  salahudheen k•265

  @salahudheen007Posted over 3 years ago

  @Da-vi-de thank you for the suggestions

  1