Design comparison
SolutionDesign
Community feedback
- @fatlindshehuPosted over 2 years ago
Hi Erkin,
Nice work with the component, there's a small issue I would recommend correcting
- I don't know why you added that margin on each card, it messes with your cards on small screen-size devices.
- Check the height of the cards when the screen decreases, the button gets out of the card.
Overall you did awesomely, keep up the good work, and happy coding!
Marked as helpful0@ErkinNPosted over 2 years ago@fatlindshehu thank you for your feedback! I couldn't fix the second issue you mentioned. It gets out of the card anyway. Can you lead me a little bit, please?
0@fatlindshehuPosted over 2 years ago@ErkinN
- Give the card class a min-height of 420px (26.25rem converted from pixels) because the card has not had enough height the element gets out of the card.
- Remove the margin: 20px auto; on the card class.
- Convert all the px units to rem units 1rem = 16px
- Use max-width and min-width instead of width for responsiveness check this LINK
- For responsive images use % instead of pixels.
Try these changes and let me know how it goes.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord