HTML5/CSS3/JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Really nice work on this challenge Tiffany, your solution looks great and scales down to mobile beautifully. I like the animation on the hamburger menu too! 🙌

  Just a quick heads up that the touchpoint on the hamburger menu is very small at the moment. Ideally, it would cover all 3 lines, but at the moment if you click on the 3rd line it doesn't activate the menu. Another approach you could use (which I also use on Frontend Mentor) is to use the button element to wrap the hamburger lines. It's still an interactive element, so is accessible to screen reader users.

  You can take a look using the dev tools to see the HTML structure. Let me know if you have any questions!

  1

  ---

  

  Tiffany Arellano•205

  @yiranoPosted about 5 years ago

  @mattstuddert I took this advice into the Bookmark LP challenge and it works so much better. Thank you for catching this and letting me know how to go about it better!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @yirano great! No problem at all 👍

  0