jordanj03• 70
@jordanj03
Posted
Very nice project however, some improvements I have:
Font-size: maybe try use the clamp function next time for your font size to make it more responsive HTML Markup: I would avoid writing "P E R F U M E" and instead using CSS properties to achieve the same effect (i.e. letter-spacing, text-transform) Also, for the image of the perfume, I would avoid using a div and floating the image as this does not account for people with screen readers. Ideally, you should use the <picture> tag and include a srcset to change the image depending on screen size
Overall, nice project, just some things I would have done differently :)
Marked as helpful
0
