@correlucas
Posted
πΎHi Ayan, congratulations for your first solution!π Welcome to the Frontend Mentor Coding Community!
I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:
Your component is okay but its missing the vertical alignment. The best way to do it is by using flexbox
. First step is to add min-height: 100vh
to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body and then use the flex properties for alignment with display: flex
/ align-items: center;
/ justify-content: center;
body {
min-height: 100vh;
background-color: var(--Cream);
display: flex;
align-items: center;
justify-content: center;
}
THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture>
tag instead of importing this as an <img>
or using a div with background-image
. Use it to place the images and make the change between mobile and desktop, instead of using a div
or img
and set the change in the css with display: none
with the tag picture is more practical and easy. Note that for SEO / search engine reasons isnβt a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture>
tag and use the html to code to set when the images should change setting the device max-width
depending of the device desktop + mobile.
Check the link for the official documentation for <picture>
in W3 SCHOOLS:
https://www.w3schools.com/tags/tag_picture.asp
βοΈ I hope this helps you and happy coding!