HTML5, SCSS, JavaScript, Media queries

Community feedback

• 

  AGsPortfolio•60

  @AGsPortfolioPosted almost 3 years ago

  I really like to thank you for your feedback? Great tips and ways to look at the html. I uploaded my new sollution

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey there, well done on completing this one. It's a good start on this challenge but there's some room for improvement in a few aspects.

  1. The intro section is very small and hard to read in mobile sizes. In the same section you keep using br for styling, but that's semantically not really correct, as there's no meaning behind where you actually put them. You could read more on this on MDN. Instead, you could just give your element a max-width. Your Get Started button could also use a bit of padding! :)

  2. Get access section isn't centered in desktop view and missing some padding-bottom in mobile sizes.

  3. I see your keep reusing the same IDs (About section, for example). IDs must be unique, meaning: one ID belongs to one element. There's little reason here to use IDs though, classes would work just fine!

  4. For both nav and footer links: it would be more semantic to use uls instead of divs, and then wrapping your links in lis.

  5. Alt texts: their purpose is to help people who for some reason can't see the images on your website, so they should be descriptive. For decorative images it's the best to leave alts empty, then screen readers will just skip it. You did nail this in some places (people's names in reviews for example), in others you could probably just skip writing alt texts altogether (like "Files" or "Productivity"), as they don't help much.

  6. Instead of section, you could add a header tag for the navigation and wrap everything in a nav.

  7. Social media links: would be nice if they were actual links, not just images so users could click on them! :) For their aria-labels it's enough to write "Facebook", "Twitter", etc, no need to include words like image, logo, etc (same goes for alt texts!).

  I hope this helps you a bit. Good luck! ^^

  0