HTML5 markup, CSS properties, Flexbox and Mobile-first workflow.

Community feedback

• 

  Luis Betancourt•160

  @betaluisPosted over 1 year ago

  Antonio,

  Congrats on completing your first project from scratch. My feedback is to notice the padding around the content and within the button. Make sure it stays consistent from mobile to desktop.

  Marked as helpful

  1

  ---

  

  AntonioPedro04•40

  @AntonioPedro04Posted over 1 year ago

  Thx you so much for the support Luis, it is nice to hear from more experienced developers. So you are suggesting that I should always set the same padding within the elements on the page even tough there are different reponsiveness configurations on my website, is that correct?

  0

  

  Luis Betancourt•160

  @betaluisPosted over 1 year ago

  @AntonioPedro04

  Of course, happy to help. Hmmm not sure if I'm understanding what you mean by that. What I'm saying is that whenever you're coding up a project from a design, make sure your padding/margins align with the design. For example, in desktop, your button is right up against the bottom, and the padding between content looks a little too large. In medium sized screens your button loses the left/right padding, and the content is right up against the edges. Same on mobile screens. Also, I'd try and make sure that the cart and "add to cart" stay on the same line in mobile instead of breaking to a new line.

  Try and figure all that out on your own. Lmk if you need more help.

  0