html5 css3(flex-fontawesome for icons)

Community feedback

• 

  Paminos•230

  @epalpamPosted about 3 years ago

  Hi Muhammad, great project, keep up the good work!!

  Some minor comments from my side:

  • try to use a README file with your github folder, it makes repo look much more professional

  • try to follow the 'mobile first' approach, meaning make first the mobile version of the design and then the tablet and desktop ones. There are a lot of pros with that approach, you can also google it.

  Hope that helps

  Marked as helpful

  1
• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi Mohamed! Awsome work layout looks good and HTML is very well structured

  some suggestions are

  • The logo should be in anchor a, logos are used to navigate on the home page in most of the cases
  • The register now should be an a link, in my opinion, using a tag and not a button. Use the button if it will act as a control for something. But on this, it is treated as a link, go for a tag.
  • Avoid too much class nesting

  hope it would help you

  Marked as helpful

  1