HTML5, CSS3

Community feedback

• 

  P

  Nitya Gulati•665

  @nityagulatiPosted almost 5 years ago

  Great work on the project, Oliver! The desktop version looks good. Next step would be to add media queries for the mobile version.

  Here's a few suggestions after quickly going through your code --

  • Instead of using position: relative and float to position the card elements, you should use Flexbox or Grid. You can check out the tutorials from Wes Bos What the Flexbox?!.

  • Look up CSS naming conventions such as BEM to use more descriptive class names instead of generic div1 div2 etc. This helps in maintaining and scaling your code easily as well as debugging.

  • You can also read up on HTML5 semantic tags for laying out your HTML structure.

  Happy Coding :)

  1