
Design comparison
Solution retrospective
I couldn't use the data.json file to add the results and total score dynamically because I don't know how to do it. I would like to learn how to do it. Any feedback on this would be really appreciated.
Community feedback
- @Kamlesh0007Posted almost 2 years ago
no its not neccessary to use data.json file in this challenge it will uneccessary consume time
Marked as helpful0 - @0xabdulkhaliqPosted almost 2 years ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
main { margin: 5rem 0rem 2rem 0rem; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@samieyongPosted almost 2 years ago@0xAbdulKhalid Wow, thanks a lot. Just implemented it. I never knew it was that easy to center components without having problem while trying to make it responsive. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord