HTML5, CSS3, and Flex Box. Made it responsive

Community feedback

• 

  Kamlesh Rajesh Yadav•5,040

  @Kamlesh0007Posted almost 2 years ago

  no its not neccessary to use data.json file in this challenge it will uneccessary consume time

  Marked as helpful

  0

  ---

  

  samieyong•60

  @samieyongPosted almost 2 years ago

  @Kamlesh0007 Ok. thanks

  0
• 

  Abdul Khaliq 🚀•72,400

  @0xabdulkhaliqPosted almost 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  main {
     margin: 5rem 0rem 2rem 0rem;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  samieyong•60

  @samieyongPosted almost 2 years ago

  @0xAbdulKhalid Wow, thanks a lot. Just implemented it. I never knew it was that easy to center components without having problem while trying to make it responsive. 👍

  0