HTML5, CSS

Community feedback

• 

  Segundo Juan•95

  @JSegundoPosted about 3 years ago

  Hi Darya, i think it's not necessary to position the div.container with position:absolute; instead i would use flexbox (justify-content:cente, align-items-centerr;)or simply a margin:0 auto; congrats on your first challenge

  Marked as helpful

  0

  ---

  

  Darya Makavchik•20

  @daryamakavchikPosted about 3 years ago

  @JSegundo thanks a lot :)

  0

  

  Segundo Juan•95

  @JSegundoPosted about 3 years ago

  @daryamakavchik My pleasure! I just uploaded my version of this challenge, maybe it helps : https://www.frontendmentor.io/solutions/html-and-scss-bA8KbHWJJ

  0
• 

  Laslow•65

  @vasilykudlotyakPosted about 3 years ago

  Hi overall it looks good but you have a few HTML issues you don't have a title element also your IMG should have alt (alternative text) it's used by screen readers for blind people and also helping get your website higher in search systems. From CSS you can change the text color to grey and the button background color to blue. But overall Good job as the first challenge you did :-)

  Marked as helpful

  0

  ---

  

  Darya Makavchik•20

  @daryamakavchikPosted about 3 years ago

  @vasilykudlotyak thank you so much! I was also worried about media query, not sure I managed it well, but guess it's ok

  0