Design comparison
Solution retrospective
Q: What did you find difficult while building the project? A: The most difficult part was adding appropriate styling so the page would look just like given example. Q: Which areas of your code are you unsure of? A: None Q: Do you have any questions about best practices? A: I do not.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
Metadata 🗃️:
- The
langattribute is used to declare the language of the webpage. Add thelangattribute to the<html>tag with the valueen.
HTML 🏷️:
- You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.
CSS 🎨:
- Avoid using
position: absoluteto center an element as it may result in overflow on some screen sizes. Instead, utilize the flexbox or grid layout for centering. Get more insights on centering in CSS here here 📘.
CSS Reset 🔄:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@NexusCypher55Posted 11 months ago@MelvinAguilar
Thanks for your feedback. Should I use paragraphs instead of headings? And I was not able to upload both html and css file, so I had to use inline css. How to upload both of them as a solution? *I know how to link css stylesheet to html, but it didn't work on GitHub ;(.
0 - The
- @danielmrz-devPosted 11 months ago
Hello @NexusCypher55!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, don't use more than one
<h1>per page. This tag should represent the main heading/subject for the whole page.
The
<h1>to<h6>tags are used to define HTML headings.<h1>defines the most important heading.<h6>defines the least important heading. Also, do not skip heading levels - start with<h1>, then use<h2>, and so on.- Also, still about semantic HTML, replace your
div.centerwithmain.center.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - For semantic reasons, don't use more than one
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord