Html y CSS - Grid Layout y Flexbox

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @carlosedugoc 👋🏻

  I have some suggestions to help you fix the accessibility issues and some other things.

  • In your markup, <div class="container">...</div> should be <main class="container">...</main> and this will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • Next, make sure to add alt text, in this case it should look like this:

  <img src="./images/image-jeremy.png" alt="Jeremy Robson">
  

  • I won't go into details about resetting CSS, but I'll leave this cool article here, which will make more sense than my brief explanation.
  • You've named the classes good enough, but if you're trying to boost productivity and improve CSS, I'd suggest learning BEM convention.
  • Also, I suggest implementing :hover state on ellipsis, which you can find in design folder active-state image, after you implement it you can also add transition: all 0.2s; to the boxes and ellipsis, this will make :hover smoother.

  I hope this was helpful 👨🏻‍💻 other than that, you did a great job, keep it up. Cheers 👾

  Marked as helpful

  0

  ---

  

  Carlos Eduardo González Cortes•50

  @carlosedugocPosted about 3 years ago

  @kens-visuals Thank you very much Ken. I will take in mind your comments for my next css projects.

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @carlosedugoc you're welcome 😇 I'd really appreciate if you could mark the comment as helpful 🙃

  0