Design comparison
SolutionDesign
Community feedback
- @SamdevtechnologyPosted over 1 year ago
Hello there π. Congratulations on a job well done! π π π
- I would like to make some suggestions concerning your code that might be of help.
HEADINGS β οΈ:
- This solution generated accessibility error report: Page should contain a level-one heading. This is due to the lack of a level-one heading <h1>.
- Headings provide structure to a webpage. It helps Search engines and Users to determine the most important piece of texts in a webpage.
- Every webpage must have at least one h1 element identifying and describing the main content(text) of the page.
- Would recommend you change <div class="...text-center text-dB"> to a <h1> element and the <div class="...text-center text-gB"> to a <p> element.
HTML π·οΈ:
- This solution generates accessibility error report: "All page content should be contained by landmarks". This is due to a non-semantic markup, which causes a lack of landmark for a webpage.
- So fix this by replacing the <div class="font-outfit m-0 bg-lG"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file.
- What is meant by landmark ?: They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>.
Well done for completing this challenge π
I hope have been of help, Please feel free to ask any question
Happy Coding π
Marked as helpful1@0xabdulkhaliqPosted over 1 year ago@Samdevtechnology Avoid Plagiarism,
According to fem guidelines, Copying others comment to earn points is to be strictly prohibited.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord