html, scss/css, responsive page

Community feedback

• 

  Radek•490

  @RadexmanPosted about 2 years ago

  Hi there, good job on that project! If you don’t mind, I will provide you with some feedback. So I checked your code and it appears that you have <h3> before <h1>, this is considered a mistake because when using headings we want to stick to the so - called hierarchy. We typically want to start from h1 and move our way to h6. Here is some good resource on that topic:

  https://www.contentkingapp.com/academy/headings/

  Also you named the classes “small” and “big” which is short and fine but we want to stick to semantic naming convention. That means that you can name your classes and id’s in a short self-explanatory way. For example “price-before” and “price-after”. Here is another awesome resource:

  https://stackoverflow.com/questions/38019/whats-the-best-approach-to-naming-classes

  Good luck on next project and happy coding!

  0