Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

html, scss/css, responsive page

@monimunozalzate

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


hi guys, i would love some feedback, any! everything is welcome, and thanks in advance Monica

Community feedback

Radek 490

@Radexman

Posted

Hi there, good job on that project! If you don’t mind, I will provide you with some feedback. So I checked your code and it appears that you have <h3> before <h1>, this is considered a mistake because when using headings we want to stick to the so - called hierarchy. We typically want to start from h1 and move our way to h6. Here is some good resource on that topic:

https://www.contentkingapp.com/academy/headings/

Also you named the classes “small” and “big” which is short and fine but we want to stick to semantic naming convention. That means that you can name your classes and id’s in a short self-explanatory way. For example “price-before” and “price-after”. Here is another awesome resource:

https://stackoverflow.com/questions/38019/whats-the-best-approach-to-naming-classes

Good luck on next project and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord