HTML SCSS Vanilla JS Eslint

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Saleh, congrats on completing this wonderful challenge! It is pretty solid and responsive. Here's a few pointers you might want to consider:

  • The form control div is a little to high and it's offsetting your design so instead of having a height property of 99px, you might want to reduce the height to height: 70px;
  • You could also add some padding to the body on the desktop view to a value of padding: 60px; and you can reduce it as soon as you reach smaller screen widths, this will make it look closer to the original design and it will bring most of your components closer to a user's focus.
  • Lastly, I like the form validation, it's really great and functioning as it's supposed to!😎

  Happy coding and keep on coding!👍

  Marked as helpful

  1

  ---

  

  Saleh•390

  @SalehAbuhusseinPosted over 2 years ago

  @tesla-ambassador Thanks For Your Feedback Ambassador ❤🥰 I am currently Stuck in Vanilla JS due to me thinking that I need more practice Do you suggest that I start practicing The Intermediate Challenges or Learn about Bundling and CSS in JS and stuff, Your Answer is Appreciated ❤

  1

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  @Honko-o You're welcome! Sorry I took long to get back, I was a little caught up. I think the best way to learn is to just practice, you can never truly be ready for anything therefore if you feel like you have properly grasped the fundamental concepts of CSS and JS, the more you practice (by taking on challenges that are relatively challenging) is the more you learn. Although if you don't feel comfortable enough with your skill level, you can always first learn the concepts you feel you need to learn until you feel comfortable enough to take on greater challenges.

  I hope this helped!😁

  0