HTML, SCSS

Community feedback

• 

  President Tree•360

  @PresidentTreePosted about 3 years ago

  For your first project on Frontend Mentor, you did really well! While I am not familiar with SCSS, there are some things I would like to point out...

  HTML

  • You have an external stylesheet, but you still included the styling for the attribution class in the head of the HTML file. Consider moving that to the stylesheet or remove it if it is not used.
  • Is the header supposed to be blank?
  • This is just me, but the slash before the img src works just as well without the slash in front of it.
  • "$59.99/year" on line 37 and the text in the attribution class do not have any tags around them like p, for example.
  • There is a lot of space between main and the attribution class.

  CSS

  • Setting the background-size to cover does not put the background-image in the right position. Consider changing it to contain.
  • You can put more than one style in @media. Just move all of your styles with the same conditions under one. @media is usually placed at the bottom of the stylesheet, too.
  • Same with the HTML images, the img src works just as well without the slash in front of it.

  You can look at my code for reference, too: https://github.com/PresidentTree/Order-Summary-Card

  Marked as helpful

  2

  ---

  

  Ildikó Balogh•80

  @liana5555Posted about 3 years ago

  @PresidentTree Thanks for the feedback. :)

  0