HTML, SCSS, JS

Community feedback

• 

  Mesut Çifci•485

  @mesutcifciPosted over 3 years ago

  Hi Grady Congrats!

  Everything looks good.

  • you can add cursor : pointer property to social media icons.

  • may be you can reduce font-size in mobile view.

  • you should give meaningful class names to html elements. c1 and c2 are not good.

  • if you use it the right way html5 semantic tags are good. I think you used the footer element in the wrong place.

  • instead of placing it under the body, if you want you can place script tag to head section with ```defer```` attribute. If you dont know what is defer just google it.

  • nesting css selectors like this .container .c2 .shift is not best practice. You should avoid this beacuse such use makes it difficult to read code and causes performance problems.

  1

  ---

  

  Grady•80

  @grady2002Posted over 3 years ago

  @mesutcifci thank you so much for the review, i will surely improve more and learn from my past errors

  Thank you for your precious time

  0