Skip to content
Submitted over 3 years ago

HTML, SCSS, JS and Testing with Mocha JS

Amon•2,560
@A-amon
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro component with sign-up form
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello! Let me know what I can improve on, especially the structure of my SCSS code (which I am still a little awkward at when coding) and testing (which I just started today!). ​Another problem I have and couldn't resolve is how do I separate the settings in one it() test function from another. For example, I set some dummy values in the input fields in one it() but the values remain when testing in the next it().

Another issue is the screen reader skipping to form after reading "Try it free for 7 days" instead of continuing to end of sentence.

Community feedback

  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    Look how narrow your inputs are becoming when the screen is sized around 830px wide ? I would change your transition points and put a width or min-width on the text input container to control it more

    1
    Amon•2,560
    @A-amonPosted over 3 years ago

    @palgramming Thank you! I have fixed it~

    0
    Patrick•14,265
    @palgrammingPosted over 3 years ago

    @A-amon 🌟🌟🌟🌟🌟 Looks great now

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord