HTML | SCSS | JavaScript | Flexbox | Grid | BEM

Community feedback

• 

  Yasser•305

  @yasserbaraghPosted over 3 years ago

  Realy good design, I like it but you do have a small problem that your intro title is overflowing @375px devices and smaller.

  0
• 

  victoriaodemakin•125

  @victoriaodemakinPosted over 3 years ago

  Really cool design. How this you get your mobile menu hamburger to animate like that. i couldn't understand the code on github and will really appreciate it if you could summarize the hamburger animation code. I'm stuck using the svg icons and will love to add animation to future project

  0

  ---

  

  Volodymyr Balashov•510

  @volod-onePosted over 3 years ago

  @victoriaodemakin Originaly I just took some code from somewhere and adjust it to my header.

  Take this link and play little bit with values. https://codepen.io/devD27/pen/oNWBwoW?editors=0100

  For each element there is two animations. Animation starts according to burger class '.active'.

  As you can see we have here 3 animation points 0, 50%, 100%.

  For active: 0 - animation start, 50% - our elements are collapsing in center, 100% - rotate.

  No more active: 0 - animation start, 50% - elements rotation equal 0, 100% - elements move apart.

  I hove my explanation will not confuse you xD

  0

  

  victoriaodemakin•125

  @victoriaodemakinPosted over 3 years ago

  @DevilDoctor27 Thank you very much for the explaining. I have a quick follow up quick. Is the burger class (.active) a pseudo-element ? i noticed a burger.active class wasn't defined in the index.html file. Everything else is clear, i'll do well to check the link. Thank you .

  0

  

  Volodymyr Balashov•510

  @volod-onePosted over 3 years ago

  @victoriaodemakin No, active is class which was added with JavaScript by click on burger menu. It is included in codeped as well.

  0
• 

  Yunus Ujjaini•565

  @yunus-ujjainiPosted over 3 years ago

  On width < 400px your text on landing page is overflowing.

  Apart from that Great job on this challenge! Happy coding

  0

  ---

  

  Volodymyr Balashov•510

  @volod-onePosted over 3 years ago

  @yunus-ujjaini Yeah, I was thinking about it. Break point on 475px looks better than standard 375px. Btw, how good or bad is adding many break points for each section? As good thing is that my design can be really good responsive but as bad just adding a big bunch of code and spending much more time. Is there something else?

  0
• 

  RAJESH J•200

  @rajesh0406Posted over 3 years ago

  I like your design .It looks better than the actual design

  0

  ---

  

  Volodymyr Balashov•510

  @volod-onePosted over 3 years ago

  @rajesh0406 haha, thank you! xD

  0