Marcin Mikos• 50
@M-Mikos
Posted
Hi! Good work, I like your usage of CSS clamp() function. Let me share some tips:
- Units: Using REM units to specify all dimensions (except very small dimensions such as
border-width: 1px) is considered a good practice because of the ease of implementing responsiveness. With REM units, all you need to do is change thefont-sizevalue of the root element (html element), and all dimensions dependent on these units will automatically scale. (https://www.freecodecamp.org/news/css-units-when-to-use-each-one/) - Files: You may be interested in implementing elements of the 7-1 pattern in your project, in order to more clearly structure your .scss files (https://sass-guidelin.es/#chapter-architecture)
- Readme: Since English is a globally recognized language, consider writing the readme file in English so most people can understand it. (https://www.freecodecamp.org/news/how-to-write-a-good-readme-file/)
Keep up the good work :)
Marked as helpful
1
Petrakowww• 40
@Petrakoow
Posted
@M-Mikos Thank you very much for the review, I will study your advice and take this into account in future projects. Regarding the README, I just made it for myself, but you are right, it is better to use English.
0
