Html, Sass, Vanilla Js to recreate the room homepage challenge

Community feedback

• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, Onyekwere Precious ~ I have studied your work, and here are some of opinions.

  First, you mentioned about image, and yes, that doesn't look good for now. You can add css property to main.showcase section:nth-child(1) .section .img-section img { object-fit: cover; }. It will improve image vision. Or you can make them background image of wrapper. That's the way I love.

  And I found out there are 13 accessibility errors. You can eliminate them by adding name or title attributes to items. And you may have to add width attribute to images that have srcset attribute.

  Hope this will help you even a bit. Happy coding ~

  2

  ---

  

  Onyekwere Precious•755

  @Yellow-MayPosted almost 4 years ago

  @axevldk thank you

  0
• 

  Madison Weber•110

  @MadisonWeberPosted almost 4 years ago

  Hey i really like the look of your site. The way the text flows down on the slideshow and then rewinds to the start is really cool. Only thing a little bit confusing for me is if i hit the right arrow you get the picture coming from the left, which for me is not what i would expect. I would think inherently if the user hits the right arrow they would expect to go to the picture on the right of the slideshow.

  0

  ---

  

  Onyekwere Precious•755

  @Yellow-MayPosted almost 4 years ago

  @MadisonWeber Thank you Yh i chose that way because i was thinking the the way that "if i click right, the current image is pushed to the right, then the next one on the left come out, and the same for left"

  It actually took me a long while to decide which side to go.

  0
• 

  positivevibes•205

  @posivibezPosted almost 4 years ago

  Nice work, I'm currently working on the same project. Kinda minor but how are you having the underline animation on the nav links scale out from the center. I'm trying looking in dev tools but don't see how you are doing that. My underlines are scaling out from left to right. Thanks and good work!

  0

  ---

  

  Onyekwere Precious•755

  @Yellow-MayPosted almost 4 years ago

  @posivibez sorry for the late reply it is not an animation, rather a transition effect and it is not an "underline" it an element i created with the before psuedo class to make it look like an underline by positioning.

  it is originally scaled down to 0 but on hover, it scales up to 1 you can look through by repo and you will see the code

  hope that helps

  0