HTML, SASS, mobile-first, vanilla JS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The images serve no other purpose then to be decorative; It adds no value. The alt tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The statistics at the bottom **are a list **, so it should be built using an unordered List element.

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  1

  ---

  

  pimoux•370

  @pimouxPosted about 2 years ago

  @vcarames thank you for sending css reset links, especially the first link which was very interesting. I will apply these changes on the next challenges that I will code now

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @pimoux

  I am glad that I was able to help out!

  Keep it up!

  1