HTML SASS Mobile First Workflow

Community feedback

• 

  Gavin•180

  @DesignAssemblyPosted over 3 years ago

  Hi @tediko, thank you for the feedback much appreciated. Yeah, my focus was definitely not on accessibility but more on layout and time boxing. if we really want to go down that rabbit hole then the first thing you need to add is a "skip to content" button (which is added in). there is way more to accessibility than a couple of tab functions. this page scored a 97 on the accessibility chart so I'm good with that. Added in the outline so all is good. thanks again and happy coding to you too.

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Gavin! 👋

  Good job on this challenge! Your solution responds well and looks nice. Some tips from me:

  • Since your .logo image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  0