Html, Sass, Javascript, Flexbox

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 2 years ago

  Hi Ricardo, visually your solution is nice, doesn't overflow on smaller viewports which is probably the most likely issue on cards like this. However, you could definitely simplify your html here, at the moment pretty much every element like a heading or a paragraph is wrapped in a separate div and that's really not necessary. You're also missing the <main> landmark and the card could really be an <article>, that's the element that components like this tend to match the best.

  For your scores, you're using input type="button" which also isn't the best option. Buttons and button type inputs should be used to perform an action, for example favouriting a page, or adding a bookmark. Here, we're selecting one of 5 options - and if you have a number of options and have to only select one, this really calls for radio inputs.

  I would also treat this as a form and use a submit event to update the selected score.

  Hope this helps :)

  Marked as helpful

  0

  ---

  

  Ricardo Fuentes Urbina•370

  @RicardoFuentes437Posted over 2 years ago

  @AgataLiberska Hello, thank you so much for your feedback :) i'll do my best to improve my code, many thanks.

  0