Skip to content
Submitted 6 months ago

HTML Sass JavaScript

KL•290
@TorHamm
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

try accessibility

What challenges did you encounter, and how did you overcome them?

nothing

What specific areas of your project would you like help with?

open or any suggestion

Community feedback

  • Boris•2,850
    @mkborisPosted 6 months ago

    Hi @TorHamm nice work, here are some suggestions that might be of interest to you.

    • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
    • Media queries should be defined in rem or em not px.
    • Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Use max-width or min-height if you absolutely have to.
    • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.

    Hope this helps.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord