Boris• 2,870
@mkboris
Posted
Hi @TorHamm nice work, here are some suggestions that might be of interest to you.
- Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Media queries should be defined in rem or em not px.
- Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Use max-width or min-height if you absolutely have to.
- It's best practice linking Google fonts directly in the HTML
headsection rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
Hope this helps.
0
