Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Html Sass flexbox grid

@pedroGermano

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

T
Matt Studdert 13,611

@mattstuddert

Posted

Awesome work on this challenge, Pedro! 👍

Here are a few pointers after taking a look at your code:

  • You currently don't have a h1 on the page, which I'd always recommend having.
  • Your input should have an aria-label attribute, as it isn't paired with a label. This will make it accessible to screen reader users.
  • I'd recommend removing the br tags from the paragraph, as you'll see on mobile it makes the text break in awkward places. Instead, let the width of the containing element dictate the width of the text.

Keep up the great work!

0

@pedroGermano

Posted

@mattstuddert thanks for the advice =)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord