HTML, SASS and Vanilla JS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  Greetings IVELIN MITEV. Congratulations for the milestone you have taken in this challenge. Here is some few suggestions:

  • where possible , make use of semantic html in place of elements such as divs - that will assist with accessibility. For example the div with id of "main" can be replaced with the mainelement.
  • the first heading of a site has to be an h1, and let the headings ascend in order without skipping. h1, h2 , h3 etc.
  • preferably use classesinstead of id's - classes are reusable and that can mean less css code.
  • all img elements should have an altattribute - thats very important for accessibility. Decorative images can have alt=""value.
  • click handlers should be associated with elements such as buttons - elements such as divs do not give all the benefit you get when using an actual button. For a div to be accessible to assistive technology users you need to apply more coding .
  • the responsiveness of the site needs improvement - check the screen at about 620px for example.
  • avoid overqualified css as they can cause some headaches to override and perfomance issues .

  #additional-info #author-info #author-name {
     font-size: 16px;
   }
  

  In this example you can just use #author-name instead of the other chain

  Marked as helpful

  2