Html page using a bit of CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello Pain3Pain, congratulations for your solution!

  Your solution isn't available to preview yet, you should do the correct setup for Github pages. I tried once to use Github Pages but was too hard so I switched to vercel.

  My advice for is to use another service for live sites, Github Pages is really tricky to setup, is full of complexity.

  If you want a quick way to display your solutions live site, the best way is using vercel.com or netlify.com that are begginer friendly and with a quick setup, in 5min your live site is on.

  All you need to do is to connect the Github account to Vercel, import the repository and deploy and there you have the live site link. With Github you've to manage too much stuff.

  Try to that and upload your solution, this way with the live site online we can help you.

  Say me then if you're able to do all the process.

  Happy coding.

  Marked as helpful

  0
• 

  Sam•230

  @samd1aPosted over 2 years ago

  Hi pain3pain, congrats on finishing your challenge it looks great!

  I managed to access your website via this link To answer your questions:

  1. The way I tend to find font sizes is by working with the size provided in the style guide, here it gives you the size of the paragraph, then using trial and error the sizes of the other elements can be worked out.
  2. I believe you have centred the image the best way in this solution. However in general, flexbox's justify-content: center; align-items: center works too.
  3. You can use the colours in style guide by replacing the hex color codes with the hsl values. e.g. background-color: hsl(220, 15%, 55%); for the background color etc.
  4. There isn't really a set way in saying which tag is better to use, however the most important text in the webpage should have the <h1> and work down from there. I recommend giving this blog post a quick read if you have time.

  Hope this helps, keep going!

  Marked as helpful

  0
• 

  Azhar•600

  @azhar1038Posted over 2 years ago

  It is working, you just don't have any index.html in your main repo. It is inside defiQR folder. So https://pain3pain.github.io/defiQR/ will show the QR code component.

  You should try to update your solution with that link.

  Marked as helpful

  0
• 

  pain3pain•10

  @pain3painPosted over 2 years ago

  Thanks a lot, but as it wasn't working, I just changed from github to Vercel. And now it works ! Understood for your tips Sam thank you, and also for tags.

  0