Html , Flex Box , Css

Community feedback

• 

  Lucas 👾•104,240

  @correlucasPosted over 2 years ago

  👾Hello Ayman, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  1.Think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

  2.THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Ayman Tarek•60

  @aymantarek16Posted over 2 years ago

  Thank you for your advice and support for me, and I have already benefited from them and I can modify this project.. I hope to follow up and evaluate some of my future works in order to see your comments and advice and benefit from your deep experience in this field.. I repeat my thanks to you, my dear

  1