Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML e CSS

Ruan Gomesβ€’ 100

@rug19

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It wasn't difficult but I've started to learn programming so there are a lot of things that I need to know, One point that I think was complicated is how to align the elements to adapt to screen size. Could someone help me with this?

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Let me explain, How you can easily center the component for better layout without usage of absolute positioning.
  • We don't need to use absolute to center the component both horizontally & vertically. Because using absolute will not dynamical centers our component at all states
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here πŸ“š.
  • For this demonstration we use css Grid to center the component
body {
min-height: 100vh;
display: grid;
place-items: center;
}
  • Now remove these styles, after removing you can able to see the changes
div {
position: absolute;
top: 25%;
left: 42%;
margin: -25px -25px;
}
  • Now your component has been properly centered.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Ruan Gomesβ€’ 100

@rug19

Posted

Thank you so much 😊. @0xAbdulKhalid

0
amrajatβ€’ 170

@amrajat

Posted

Congratulation on submitting the challenge. I have a few suggestions please consider refactoring its code if you find it useful.

  • You can align this component horizontally and vertically by multiple hacks such as margins, display: flex + justify-content: center + align-items: center, or by display: grid, place-items: center.

  • you should have a minimum of one h1 heading per page for accessibility.

happy coding :)

Marked as helpful

0

Ruan Gomesβ€’ 100

@rug19

Posted

Thank you so much ☺️. @amrajat

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord