Design comparison
SolutionDesign
Solution retrospective
Estou muito feliz com o resultado. agradeço qualquer feedback.
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hi Bruno e Sousa Alencar,
Excellent work! I have some suggestions regarding your solution, if you don't mind:
- it's not recommended to capitalize in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalized text as they will often read them letter by letter thinking they are acronyms.
- Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s
for
attribute value must match its input’sid
value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may usesr-only
class ).
Validating forms using JavaScript:
- The
aria-live
attribute is set on that error message to make sure that error message will be presented to everyone, including it being read out to ** screen reader users**.
- A key point here is that setting the
novalidate
attribute on the form is what stops the form from showing its own error message bubbles.
hopefully this feedback helps.
0@BrunoeSousaAlencarPosted about 2 years ago@PhoenixDev22 Muito obrigado pelas dicas, levarem em consideração nos meu próximos projetos.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord