HTML, CSS/Sass,JavaScript

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Gassai Hamza!

  I have some feedback on this solution:

  • For any decorative images, you should leave the alt="" empty and add aria-hidden="true" to make all screen readers ignore those images. In this case, all images except the logo are decorative images.
  • Always avoid inline styling. It's a bad practice and cause a lot of specificity issues. Put all your styling on your CSS file (in this case your Scss file).
  • Also, you don't need JavaScript to validate the email input in this challenge. Just use the native validation and :invalid pseudo-class to show the alert message.
  • Use rem or sometimes em instead of px. Using px make the users can't control the size of this page based on their needs. Create Sass function that will convert px to rem.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Gassai Hamza•290

  @GHamza-DevPosted about 3 years ago

  @vanzasetia

  • Thank you so much Vanza Setia! it's very helpfullllllll

  0